www

commit b88bc7723d2d7695d38e0c9cb11be3edac1a28f2
parent 4297eb127621a64957d10ac29cb5d453e1f90f61
Author: Eddie Kohler <ekohler@gmail.com>
Date:   Mon, 28 Nov 2016 09:59:28 -0500

Italic correction should not be applied to characters in text mode.

This requires changes to screenshotter tests that assumed italic
correction was applied in text mode.

Diffstat:
M
src/buildCommon.js
 | 
6
+++++-
M
test/screenshotter/images/Cases-chrome.png
 | 
0

M
test/screenshotter/images/Cases-firefox.png
 | 
0

M
test/screenshotter/images/DashesAndQuotes-chrome.png
 | 
0

M
test/screenshotter/images/DashesAndQuotes-firefox.png
 | 
0

M
test/screenshotter/images/StackRel-chrome.png
 | 
0

M
test/screenshotter/images/StackRel-firefox.png
 | 
0

M
test/screenshotter/images/Unicode-chrome.png
 | 
0

M
test/screenshotter/images/Unicode-firefox.png
 | 
0

M
test/screenshotter/images/UnsupportedCmds-chrome.png
 | 
0

M
test/screenshotter/images/UnsupportedCmds-firefox.png
 | 
0

11 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/buildCommon.js b/src/buildCommon.js
@@ -49,8 +49,12 @@ var makeSymbol = function(value, fontFamily, mode, options, classes) {
 
     var symbolNode;
     if (metrics) {
+        var italic = metrics.italic;
+        if (mode === "text") {
+            italic = 0;
+        }
         symbolNode = new domTree.symbolNode(
-            value, metrics.height, metrics.depth, metrics.italic, metrics.skew,
+            value, metrics.height, metrics.depth, italic, metrics.skew,
             classes);
     } else {
         // TODO(emily): Figure out a good way to only print this in development
diff --git a/test/screenshotter/images/Cases-chrome.png b/test/screenshotter/images/Cases-chrome.png
Binary files differ.
diff --git a/test/screenshotter/images/Cases-firefox.png b/test/screenshotter/images/Cases-firefox.png
Binary files differ.
diff --git a/test/screenshotter/images/DashesAndQuotes-chrome.png b/test/screenshotter/images/DashesAndQuotes-chrome.png
Binary files differ.
diff --git a/test/screenshotter/images/DashesAndQuotes-firefox.png b/test/screenshotter/images/DashesAndQuotes-firefox.png
Binary files differ.
diff --git a/test/screenshotter/images/StackRel-chrome.png b/test/screenshotter/images/StackRel-chrome.png
Binary files differ.
diff --git a/test/screenshotter/images/StackRel-firefox.png b/test/screenshotter/images/StackRel-firefox.png
Binary files differ.
diff --git a/test/screenshotter/images/Unicode-chrome.png b/test/screenshotter/images/Unicode-chrome.png
Binary files differ.
diff --git a/test/screenshotter/images/Unicode-firefox.png b/test/screenshotter/images/Unicode-firefox.png
Binary files differ.
diff --git a/test/screenshotter/images/UnsupportedCmds-chrome.png b/test/screenshotter/images/UnsupportedCmds-chrome.png
Binary files differ.
diff --git a/test/screenshotter/images/UnsupportedCmds-firefox.png b/test/screenshotter/images/UnsupportedCmds-firefox.png
Binary files differ.